Skip to main content Help Control Panel

 

English «   Bug tracker «  

Security Problem with Comments - Need Fix Asap

Anstey Stephan -- on Feb. 4 2008

Comments on Associate only threads are exposed by the search engine.

WorkflowSupport request
StatusProblem has been recorded
OwnerAnstey Stephan
Progress0%
When a member searches the site the results include comments by our members in theoreticaly secure threads.

Files

Comments.zip - 10,668 bytes, 71 downloads
edited by Dobliu on June 22 2008 · details

Comments


Anstey Stephan
305 posts

on Feb. 4 2008


I have commented out the code on search.php that searches the comments until this is resolved. If you want me to uncomment and show you my results, let me know.
  • verified that search was done logged completely out
  • verified that comments shown were in associate thread


The concern is that we often use the comments for sensitive private data.

Bernard Paquesfrom nearby-an-airport
Associate, 8408 posts

on Feb. 7 2008


Ok, I will do the same, and comment out the released code until a solution is find.

Dobliufrom L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
216 posts

on Feb. 10 2008


Hello anteyER,

it's a major bug in YACS. Several months ago, i have posted a solution on French forum, due i think, a missing of time it was not reused in news releases. Code below in function search file comments.php; it is running with mysql version = or > v4.1, YACS 7.12 or 8.1,

Click to slide


Bernard Paquesfrom nearby-an-airport
Associate, 8408 posts

inspired from dobliu on Feb. 10 2008


Dobliu: What is the minimum version of MySQL that supports combined SELECT statements such as the one you propose ?

Dobliufrom L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
216 posts

on Feb. 10 2008


Bernard:
"subselect"  in Mysql  4.1, better compliance with SQL specifications.
Below 4.1, only  INSERT ... SELECT ...   and REPLACE ... SELECT ...,  but i have not checked .
I use mysql 5;  in others case  using   JOIN instruction  can be a solution.

 

 


Dobliufrom L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
216 posts

on Mar. 7 2008


hello all

where is the search comment patch ?

Bernard, do you have a feeback on the suggested fix ?

is it in version 8.2 ?

bye ...

 

 


Anstey Stephan
305 posts

on Mar. 7 2008


I am using mysql MySQL 5.0.24

are there any particular settings that might be wrong in my version?

Anstey Stephan
305 posts

inspired from ansteyER on Mar. 7 2008


So i should find comment.php and replace the function there with this code?

Dobliufrom L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
216 posts

on Mar. 7 2008


hello ansteyER :

do you have opened the folder  in  above comment  :

"Hello anteyER,

it's a major bug in YACS. Several months ago, i have posted a solution on French forum, due i think, a missing of time it was not reused in news releases. Code below in function search file comments.php; it is running with mysql version = or > v4.1, YACS 7.12 or 8.1,

 

Cliquer pour plier ou déplier Cliquer pour plier/déplier

"


Bernard Paquesfrom nearby-an-airport
Associate, 8408 posts

on June 20 2008


Dobliu, at the moment the core code of yacs does not allow for search requests in comments, nor in links, to preserve confidentiality.

If you wish, please provide an updated version of search.php and of related scripts, that could be integrated in July release.

Dobliufrom L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
216 posts

on June 22 2008


Dear YACSER'S,

Find attached this latest update of comments.php file  release 8.1. 

Don't forget to activate the search  in comments (search.php)

i am very busy during last days, and for the 8.5 release, i have not make a  revision.

Bye ...

 




comments.zip