Skip to main content Help Control Panel

 

English «   Bug tracker «  

Problems with Google Maps URLs [fixed]

Just started moving a site to YACS (only 4 pages) and the only problem I have come across is that the google maps URL does seem to work (using the YACS click.php link system)

http://www.room42hairsalon.co.uk/yacs/

I don't know if this is a bug (but will investigate when I get time).

Cheers, Nick

Bernard Paquesfrom nearby-an-airport
Associate, 8405 posts

on Dec. 6 2006


Nick, YACS 6.10 features a filter to ensure harmless URLs. Maybe this filter is too strong and strip some characters of the link. Can you please provide the link to let me check that?
NickR

inspired from Bernard on Dec. 6 2006


the (long) Google URL
:)

Edited by Bernard on Dec. 7 2006


Bernard Paquesfrom nearby-an-airport
Associate, 8405 posts

inspired from NickR on Dec. 7 2006


NickR: Ok, apparently characters ',' and '+' were missing from the new filter. Fixed in shared/global.php at lines 119:

if(!defined('FORBIDDEN_CHARS_IN_URLS'))
    
define('FORBIDDEN_CHARS_IN_URLS''/[^\w~_:@\/\.&#;\,+%\?=-]+/');


Also, the filter applied to links has to changed at line 489 of codes/codes.php as follows:

function &clean_href($text) {

    
// suppress invalid chars
    
$output =& preg_replace(FORBIDDEN_CHARS_IN_URLS'_'stripslashes($text));
    return 
$output;

}